Re: [PATCH v12 01/30] tracing: Update cond flag when enabling or disabling a trigger

[Namhyung Kim]

Hi Steve and Tom,

On Mon, Nov 23, 2015 at 04:29:43PM -0500, Steven Rostedt wrote:
> On Mon, 23 Nov 2015 13:51:16 -0600
> Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:
> 
> > When a trigger is enabled, the cond flag should be set beforehand,
> > otherwise a trigger that's expecting to process a trace record
> > (e.g. one with post_trigger set) could be invoked without one.
> > 
> > Likewise a trigger's cond flag should be reset after it's disabled,
> > not before.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> > Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > ---
> 
> FYI, I've applied this patch as it looks like something that should be
> added regardless of the rest of the series.

You can add my Reviewed-by if you want.  I'll try to review others soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/