Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

From: Måns Rullgård
Date: Wed Nov 25 2015 - 07:11:22 EST


Mason <slash.tmp@xxxxxxx> writes:

> [ Trimming CC list ]
>
> On 19/11/2015 19:33, Mans Rullgard wrote:
>
>> +config TANGOX_IRQ
>
> Could you drop the X?

Sure, if that's what people prefer.

> (And perhaps change IRQ to IRQCHIP? What's the current trend?)

Most of the existing entries say just IRQ or something completely ad
hoc, only 4 IRQCHIP.

>> + bool
>> + select IRQ_DOMAIN
>> + select GENERIC_IRQ_CHIP
>
> Could you sort alphabetically, like the mach Kconfig?

Tell that to all the other ones. Oh well, whatever.

--
Måns Rullgård
mans@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/