Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

[Ulf Hansson]

[...]

>> +sdhci_pic32_probe_dts(struct platform_device *pdev,
>> +                     struct pic32_sdhci_pdata *boarddata)
>> +{
>> +       struct device_node *np = pdev->dev.of_node;
>> +
>> +       if (!np)
>> +               return -ENODEV;
>> +
>> +       if (of_find_property(np, "no-1-8-v", NULL))
>
> Please don't use this property as it's broken. It has two different
> purposes and those are conflicting as discussed here[1].

Realized that I forgot to attach the reference to the discussion, here it is.

[1]
http://comments.gmane.org/gmane.linux.kernel.mmc/32751

>
> You have two options, either invent a new binding which provides
> information about which signal voltage that *is* supported, or use the
> current existing common MMC dt bindings to override the SDHCI
> capabilities register.
>

[...]

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/