Re: [PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags

[Alexandre Belloni]

Hi,

On 25/11/2015 at 23:49:57 +0530, Saurabh Sengar wrote :
> If no primary handler is specified for threaded_irq then a
> default one is assigned which always returns IRQ_WAKE_THREAD.
> This handler requires the IRQF_ONESHOT, because the source of
> interrupt is not disabled
> 

Are you sure this is necessary? The parent irqchip is the mfd and it
sets IRQF_ONESHOT.

Does that solve a real problem or is it a false positive coming from a
static analysis tool?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/