Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate()

From: Tejun Heo
Date: Wed Nov 25 2015 - 15:41:11 EST


On Wed, Nov 25, 2015 at 02:54:10PM -0500, Tejun Heo wrote:
> On Wed, Nov 25, 2015 at 02:51:38PM -0500, Tejun Heo wrote:
> > Sounds perfect. As this needs to go through -stable, can you please
> > resend the patch with proper description and SOB? Please also update
> > the now incorrect comment in can_attach.
>
> Ooh, the patch triggers RCU warning from task_css(). It's spurious
> and I think the right thing to do at least for now is using
> task_css_check() and explain what's going on.

And I spotted a bug in cgroup core in controller enable path. While
the race between fork and attach exists and needs to be fixed, I think
the cgroup core bug is the main source of discrepancy. Will update
once I learn more.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/