checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines

[Shawn N]

Hello,

The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
a minimum description when citing patches: 'commit <12+ chars of sha1>
(\"<title line>\")'. One (unintended?) consequence of this rule is
that unmodified 'cherry picked from commit <sha1>' (git cherry-pick
-x) lines are flagged.

- Is the disallowing of 'cherry picked from commit <sha1>' lines by
GIT_COMMIT_ID working as intended?
- If yes, would it be acceptable to instead add a new rule with
clearer error output ("Don't include git cherry-pick -x description
lines")?
- If no (and such lines are actually acceptable) then I will just
patch the GIT_COMMIT_ID rule.

Thanks,

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/