Re: [PATCH 2/3] perf build: Use FEATURE-INCLUDE in bpf subproject

[Jiri Olsa]

On Thu, Nov 26, 2015 at 01:31:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 26, 2015 at 02:54:03PM +0100, Jiri Olsa escreveu:
> > Using FEATURE-INCLUDE in bpf subproject in case bpf is built
> > via perf. Keep the current features detection for other cases.
> > 
> > Cc: Wang Nan <wangnan0@xxxxxxxxxx>
> > Link: http://lkml.kernel.org/n/tip-utuczk899ckz6qtggqvhm7yu@xxxxxxxxxxxxxx
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> 
> Clashes with:
> 
> d8ad6a15cc3a ("tools lib bpf: Don't do a feature check when cleaning")
> 
> That has, at that point:
> 
> +check_feat := 1
> +NON_CHECK_FEAT_TARGETS := clean TAGS tags cscope help
> +ifdef MAKECMDGOALS
> +ifeq ($(filter-out $(NON_CHECK_FEAT_TARGETS),$(MAKECMDGOALS)),)
> +  check_feat := 0
> +endif
> +endif
> +
> +ifeq ($(check_feat),1)
>  include $(srctree)/tools/build/Makefile.feature
> +endif
> 
> On a related note:
> 
>   [acme@zoo linux]$ make O=/tmp/build/perf -C tools/perf
>   make: Entering directory '/home/git/linux/tools/perf'
>     BUILD:   Doing 'make -j4' parallel build
>   make[2]: Nothing to be done for 'fixdep'.
>   make: Leaving directory '/home/git/linux/tools/perf'
> 
> Can we get away with that "make[2]: Nothing to be done for 'fixdep'."
> line?

I'll check on that

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/