Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller

[Arnd Bergmann]

On Friday 27 November 2015 20:32:03 Bharat Kumar Gogada wrote:
> +       do {
> +               err = nwl_pcie_link_up(pcie, PHY_RDY_LINKUP);
> +               if (err != 1) {
> +                       check_link_up++;
> +                       if (check_link_up > LINKUP_ITER_CHECK)
> +                               return -ENODEV;
> +                       mdelay(1000);
> +               }
> +       } while (!err);

mdelay(1000) is not something anyone should do. Why can't you call
a sleeping function here?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/