Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support

[Arnd Bergmann]

On Friday 27 November 2015 09:37:45 Ray Jui wrote:
> 
> +static const struct of_device_id iproc_pcie_of_match_table[] = {
> +       {
> +               .compatible = "brcm,iproc-pcie",
> +               .data = (int *)IPROC_PCIE_PAXB,
> +       }, {
> +               .compatible = "brcm,iproc-pcie-paxc",
> +               .data = (int *)IPROC_PCIE_PAXC,
> +       },
> +       { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, iproc_pcie_of_match_table);

You seem to only need the identifiers in order to set a single
pointer, so just point to that array directly. Alternatively,
do the more common thing and point to a structure of function
pointers and have different implementations of the low-level
access functions there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/