Re: [PATCH v2 4/9] Documentation: dt-bindings: regulator: add LM363x regulator binding information

[Rob Herring]

On Thu, Nov 26, 2015 at 03:57:00PM +0900, Milo Kim wrote:
> This binding describes LM3631 and LM3632 regulator properties.
> 
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Lee Jones <lee.jones@xxxxxxxxxx> 
> Cc: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: linux-leds@xxxxxxxxxxxxxxx 
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> ---
>  .../bindings/regulator/lm363x-regulator.txt        | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt b/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
> new file mode 100644
> index 0000000..8f14df9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
> @@ -0,0 +1,34 @@
> +TI LMU LM363x regulator device tree bindings
> +
> +LM363x regulator driver supports LM3631 and LM3632.
> +LM3631 has five regulators and LM3632 supports three regulators.
> +
> +Required property:
> +  - compatible: "ti,lm363x-regulator"
> +
> +Optional properties:
> +  LM3632 has external enable pins for two LDOs.
> +  - ti,lcm-en1-gpio: A GPIO specifier for Vpos control pin.
> +  - ti,lcm-en2-gpio: A GPIO specifier for Vneg control pin.

Use "-gpios" please.

> +
> +Child nodes:
> +  LM3631
> +  - vboost
> +  - vcont
> +  - voref
> +  - vpos
> +  - vneg
> +
> +  LM3632
> +  - vboost
> +  - vpos
> +  - vneg
> +
> +  Optional properties of a child node:
> +  Each sub-node should contain the constraints and initialization.
> +  Please refer to [1].

What about the regulator names?

> +
> +Examples: Please refer to ti-lmu dt-bindings [2].
> +
> +[1] ../regulator/regulator.txt
> +[2] ../mfd/ti-lmu.txt
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/