Re: [PATCH 1/3] usb: musb: convert printk to pr_*

[Sergei Shtylyov]

On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote:

> > > This file already uses pr_debug in a few places; this converts the
> > > remaining printks.
> >
> >     Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent?
>
> Yes, and that is a good thing, you should be using pr_debug() instead of
> printk(KERN_DEBUG...).
>
> Why object to something like this?

   I'm not objecting, just asking. There have been many cases in my practice 
where a patch author wasn't aware of that...
   It's just that these printk()'s could have been intentional (not to depend 
on DEBUG or dynamic debugging).

> greg k-h

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/