Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force

[Daniel Vetter]

On Fri, Nov 27, 2015 at 03:29:52PM +0000, Emil Velikov wrote:
> On 27 November 2015 at 15:10, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> > This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset
> > drivers.
> >
> > v2: Make the dummy function actually return a sane value, spotted by
> > Ville.
> >
> > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > ---
> >  drivers/gpu/drm/ast/ast_drv.c         | 2 --
> >  drivers/gpu/drm/cirrus/cirrus_drv.c   | 2 --
> >  drivers/gpu/drm/i915/i915_drv.c       | 2 --
> >  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 --
> >  drivers/gpu/drm/nouveau/nouveau_drm.c | 2 --
> >  drivers/gpu/drm/qxl/qxl_drv.c         | 2 --
> >  drivers/gpu/drm/radeon/radeon_drv.c   | 2 --
> >  include/linux/console.h               | 2 ++
> 
> The new drivers seems to be missing the conversion. Namely amdgpu and
> virtio_gpu.

Just shows how old this patch is ;-) And it's not going to cause a
problem since this patch simply makes the #ifdef redundant.

Greg, do you prefer a respin or a fixup patch?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/