Re: [radeon r100] when ring test fails, provide users with option to test
From: Christian KÃnig
Date: Sun Nov 29 2015 - 14:49:44 EST
On 28.11.2015 21:58, Pavel Machek wrote:
Ring test failure is often caused by too high agpmode. Tell the user
what to try.
Signed-off-by: Pavel Machek <pavel@xxxxxx>
NAK, the ring test can fail for any number of reasons and the agpmode is
actually rather unlikely to be the cause.
Regards,
Christian.
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 238b13f..32b1917 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
if (i < rdev->usec_timeout) {
DRM_INFO("ring test succeeded in %d usecs\n", i);
} else {
- DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
+ DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
scratch, tmp);
r = -EINVAL;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/