Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

[Saurabh Sengar]

pinging in case this patch is lost.


On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.truth@xxxxxxxxx> wrote:
> added iounmap inorder to free memory mapped to base before returning
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@xxxxxxxxx>
> ---
>  drivers/usb/host/pci-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..332f687 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>                         /* We're reading garbage from the controller */
>                         dev_warn(&pdev->dev,
>                                  "xHCI controller failing to respond");
> -                       return;
> +                       goto iounmap;
>                 }
>
>                 if (!ext_cap_offset)
> @@ -1061,7 +1061,7 @@ hc_init:
>                          "xHCI HW did not halt within %d usec status = 0x%x\n",
>                          XHCI_MAX_HALT_USEC, val);
>         }
> -
> +iounmap:
>         iounmap(base);
>  }
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/