Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional

[Linus Walleij]

On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@xxxxxxxxxxxxx> wrote:

> -       if (IS_ERR(i2c_imx->pinctrl)) {
> +       /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> +       if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> +                       PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {

This is one of the evils of deferred probe: you never know if
something will eventually turn up. It feels wrong to bail out
on deferred probe...

I have no better idea though.
Acked-by

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/