Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

[David Miller]

From: Salil Mehta <salil.mehta@xxxxxxxxxx>
Date: Thu, 26 Nov 2015 07:14:06 +0000

> -#define ENABLE		(0x1)
> -#define DISABLE		(0x0)
> +#define ENABLE		0x1
> +#define DISABLE		0x0

Defining such common macros names for such incredibly simple boolean values
is asking for trouble, in particular it can possibly collide with other
defines in the global namespace.

Use "true", "false", and the "bool" type, because that is exactly how you
are using these values.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/