Re: [PATCH] mtd: nand: fix ONFI parameter page layout

[Brian Norris]

On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote:
> src_ssync_features field is only 1 byte large, and the 4th reserved area
> is actually 8 bytes large.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device")
> Cc: <stable@xxxxxxxxxxxxxxx> #v2.6.37+

Did you see an actual problem from this? (And is this deserving of
stable?) I could imagine an out-of-tree driver might try to use t_ald
(which should actually be t_adl, right?) and get the wrong value. But no
one does that in-tree yet.

> ---
>  include/linux/mtd/nand.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index 5a9d1d4..93fc372 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -276,7 +276,7 @@ struct nand_onfi_params {
>  	__le16 t_r;
>  	__le16 t_ccs;
>  	__le16 src_sync_timing_mode;
> -	__le16 src_ssync_features;
> +	u8 src_ssync_features;
>  	__le16 clk_pin_capacitance_typ;
>  	__le16 io_pin_capacitance_typ;
>  	__le16 input_pin_capacitance_typ;
> @@ -284,7 +284,7 @@ struct nand_onfi_params {
>  	u8 driver_strength_support;
>  	__le16 t_int_r;
>  	__le16 t_ald;
> -	u8 reserved4[7];
> +	u8 reserved4[8];
>  
>  	/* vendor */
>  	__le16 vendor_revision;

Patch looks good.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/