Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

[kbuild test robot]

Hi David,

[auto build test WARNING on: net-next/master]
[also build test WARNING on: v4.4-rc3 next-20151127]

url:    https://github.com/0day-ci/linux/commits/David-Decotigny/RFC-new-ETHTOOL_GSETTINGS-SSETTINGS-API/20151201-062040
config: blackfin-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   In file included from include/linux/netdevice.h:42:0,
                    from drivers/staging/rtl8723au/include/osdep_service.h:30,
                    from drivers/staging/rtl8723au/core/rtw_cmd.c:17:
   include/linux/ethtool.h: In function '__ethtool_add_link_modes':
>> include/linux/ethtool.h:129:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

vim +129 include/linux/ethtool.h

   113		struct {
   114			ethtool_link_mode_mask_t supported;
   115			ethtool_link_mode_mask_t advertising;
   116			ethtool_link_mode_mask_t lp_advertising;
   117		} link_modes;
   118	};
   119	
   120	/* helper function for ethtool_build_link_mode and ethtool_add_link_modes */
   121	static inline int
   122	__ethtool_add_link_modes(ethtool_link_mode_mask_t *dst,
   123				 unsigned nindices,
   124				 const enum ethtool_link_mode_bit_indices *indices) {
   125		unsigned i;
   126		int rv = 0;
   127	
   128		for (i = 0 ; i < nindices ; ++i) {
 > 129			if (__ETHTOOL_LINK_MODE_IS_VALID_BIT(indices[i]))
   130				set_bit(indices[i], dst->mask);
   131			else
   132				rv = -1;
   133		}
   134		return rv;
   135	}
   136	
   137	/* build link mode mask from variadic list of bit indices, return 0

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data