Re: [PATCH] mtd: nand: fix ONFI parameter page layout

[Boris Brezillon]

On Tue, 1 Dec 2015 11:05:10 -0800
Brian Norris <computersforpeace@xxxxxxxxx> wrote:

> On Tue, Dec 01, 2015 at 10:33:18AM +0100, Boris Brezillon wrote:
> > On Mon, 30 Nov 2015 12:17:29 -0800
> > Brian Norris <computersforpeace@xxxxxxxxx> wrote:
> > > On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote:
> > > > src_ssync_features field is only 1 byte large, and the 4th reserved area
> > > > is actually 8 bytes large.
> > > > 
> > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > > > Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device")
> > > > Cc: <stable@xxxxxxxxxxxxxxx> #v2.6.37+
> > > 
> > > Did you see an actual problem from this? (And is this deserving of
> > > stable?) I could imagine an out-of-tree driver might try to use t_ald
> > > (which should actually be t_adl, right?)
> > 
> > Yes, should be t_adl, not t_ald. Do you want me to send another patch
> > for that, or will you take care of it?
> 
> I'll send a quick patch.
> 
> > > and get the wrong value. But no
> > > one does that in-tree yet.
> > 
> > Fair enough, we can just drop the stable and fixes tag. Do you want me
> > to resend it?
> 
> I presume this means you didn't see any actual problems caused by this
> patch, other than new development referencing it?

Yep, I noticed the problem when playing with the driver strength
feature.

> 
> Applied without the stable tag. I kept the fixes tag.
> 
> Thanks,
> Brian



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/