Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

From: Mark Brown
Date: Tue Dec 01 2015 - 14:58:59 EST


On Tue, Dec 01, 2015 at 04:51:06PM -0000, Michal Suchanek wrote:
> On some SPI controllers it is not feasible to transfer arbitrary amount
> of data at once.
>
> When the limit on transfer size is a few kilobytes at least it makes
> sense to use the SPI hardware rather than reverting to gpio driver.

> + /*
> + * on some hardware transfer size may be constrained
> + * the limit may depend on device transfer settings
> + */
> + size_t (*max_transfer_size)(struct spi_device *spi);

Heiner submitted a *very* similar patch just now with a straight
variable plus accessor instead of a function and using a name with _msg.
I'm ambivalent on the implementation but prefer the naming here since
that's more the limitation we're trying to express I think (some
hardware does have limiations about multple transfers too). Can the two
of you come up with something that works for both of you?

Attachment: signature.asc
Description: PGP signature