Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

From: David Miller
Date: Tue Dec 01 2015 - 15:35:26 EST


From: Michal Hocko <mhocko@xxxxxxxxxx>
Date: Mon, 30 Nov 2015 14:21:29 +0100

> On Sat 28-11-15 15:51:13, Pavel Machek wrote:
>>
>> atl1c driver is doing order-4 allocation with GFP_ATOMIC
>> priority. That often breaks networking after resume. Switch to
>> GFP_KERNEL. Still not ideal, but should be significantly better.
>
> It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither
> from the changelog nor from the patch context.

Earlier in the function we do a GFP_KERNEL kmalloc so:

Â\_(ã)_/Â

It should be fine.