Re: [PATCH v3 0/3] soc: ti: Introduce wkup_m3_ipc driver

From: Dave Gerlach
Date: Wed Dec 02 2015 - 15:30:24 EST


Hi,
On 10/20/2015 11:18 AM, Tony Lindgren wrote:
Hi all,

* Dave Gerlach <d-gerlach@xxxxxx> [150922 17:20]:
Hi,
This series is version 3 of the code to introduce a wkup_m3_ipc driver
to handle communication between the MPU and Cortex M3 present on TI AM335x
and AM437x SoCs. v2 of this series can be found at [1]. Only patch 3
has been changed based on a request from Tony and a few cleanups:

- Rather than exporting all of the functionality of the driver, added
wkup_m3_ipc_get and wkup_m3_ipc_put to allow users to just get a handle
containing an ops structure for use.

- Changed all ops (previously exported functions) to take pointer to
struct wkup_m3_ipc as an argument now that user code will get this
from wkup_m3_ipc_get.

- General cleanup to probe function

- Added MODULE_DEVICE_TABLE so driver can probe automatically.

The series containing the DT nodes can be found here [2]. The actual dt
nodes for wkup_m3_ipc (last two patches) have been merged but discussion
is still open for the ti,mbox-send-noirq flag patches and depends on the
comments provided for the omap-mailbox change presented in patch 1 of
this series.

A full branch containing all necessary PM code for both am335x and am437x
has been pushed here [3] to provide a big picture view of the plan for
this series.

This driver relies on the firmware at [4] in the next-upstream branch
being present in /lib/firmware in the rootfs or built in to the kernel.

Anybody got comments on this one? Should I pick up this series or
what's the plan?

Now that Patch 1 has been merged [1] can patch 2 and 3 be picked up? These apply cleanly on v4.4-rc3.

Regards,
Dave

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8e3c5952144f045a0c81bf674d3f5e1d9aafceb7


Regards,

Tony


[1] https://lkml.org/lkml/2015/7/17/797
[2] https://lkml.org/lkml/2015/7/17/813
[3] https://github.com/dgerlach/linux-pm/tree/pm-v4.3-rc1-amx3-suspend
[4] https://git.ti.com/ti-cm3-pm-firmware

Dave Gerlach (3):
mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle
Documentation: dt: add bindings for TI Wakeup M3 IPC device
soc: ti: Add wkup_m3_ipc driver

.../devicetree/bindings/mailbox/omap-mailbox.txt | 8 +
.../devicetree/bindings/soc/ti/wkup_m3_ipc.txt | 57 +++
drivers/mailbox/omap-mailbox.c | 49 +-
drivers/soc/ti/Kconfig | 10 +
drivers/soc/ti/Makefile | 1 +
drivers/soc/ti/wkup_m3_ipc.c | 508 +++++++++++++++++++++
include/linux/wkup_m3_ipc.h | 55 +++
7 files changed, 684 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/ti/wkup_m3_ipc.txt
create mode 100644 drivers/soc/ti/wkup_m3_ipc.c
create mode 100644 include/linux/wkup_m3_ipc.h

--
2.4.6


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/