Re: [PATCH v2] usb: ehci: ohci: use true/false for bool

[Geyslan G. Bem]

2015-12-02 19:23 GMT-03:00 Geyslan G. Bem <geyslan@xxxxxxxxx>:
> 2015-12-02 19:16 GMT-03:00 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
>> On Wed, Dec 02, 2015 at 07:09:19PM -0300, Geyslan G. Bem wrote:
>>> When declaring/initializing bool use true instead of 1. If it's false,
>>> there's no need to explicit initialize it, once it's default.
>>>
>>> Caught by coccinelle.
>>>
>>> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
>>> ---
>>>  drivers/usb/host/ehci-hcd.c | 2 +-
>>>  drivers/usb/host/ohci-hcd.c | 4 ++--
>>>  drivers/usb/host/u132-hcd.c | 2 +-
>>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
>>> index 48c92bf..1b01967 100644
>>> --- a/drivers/usb/host/ehci-hcd.c
>>> +++ b/drivers/usb/host/ehci-hcd.c
>>> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);
>>>  MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
>>>
>>>  /* for flakey hardware, ignore overcurrent indicators */
>>> -static bool ignore_oc = 0;
>>> +static bool ignore_oc;
>>
>> This should be a separate patch as it's doing something differently than
>> what you describe.
>>
>> thanks,
>>
>> greg k-h
>
> Greg,
>
> I think that the v2 description is ok, the title is misleading indeed.
> I'll make a new one entitled "fix bool initialization". Anything else?

Please ignore my last statements.

Report to this: [PATCH] usb: ehci: ohci: fix bool assignments

>
> Thanks.
>
> --
> Regards,
>
> Geyslan G. Bem
> hackingbits.com



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/