Re: [PATCH v4 0/4] drm: Add support for the ARM HDLCD display controller

[Russell King - ARM Linux]

On Thu, Dec 03, 2015 at 10:40:45AM +0000, Liviu Dudau wrote:
> This series depends on Sudeep Holla's SCPI driver (now in mainline) and on
> the tda998x patches that have been queued on Russell's patch system here [1].

Now merged into my tree.

Can I ask a fairly obvious question...

>  drivers/gpu/drm/Kconfig                            |   2 +
>  drivers/gpu/drm/Makefile                           |   1 +
>  drivers/gpu/drm/arm/Kconfig                        |  29 ++
>  drivers/gpu/drm/arm/Makefile                       |   2 +
>  drivers/gpu/drm/arm/hdlcd_crtc.c                   | 327 ++++++++++++
>  drivers/gpu/drm/arm/hdlcd_drv.c                    | 555 +++++++++++++++++++++
>  drivers/gpu/drm/arm/hdlcd_drv.h                    |  42 ++
>  drivers/gpu/drm/arm/hdlcd_regs.h                   |  87 ++++

Why is the subdirectory called "arm" and not "hdlcd" ?

ARM Ltd have more than one display controller (they have the AMBA PL110
and PL111 in addition to this), and (afaics) this doesn't drive these.
HDLCD probably won't be the last display hardware which ARM Ltd comes
out with either.

So, I think naming the subdirectory after the vendor is probably a
mistake.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/