Re: [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles

From: Dilger, Andreas
Date: Fri Dec 04 2015 - 01:23:50 EST


On 2015/12/01, 15:05, "Valdis Kletnieks" <Valdis.Kletnieks@xxxxxx> wrote:

>Start of a batch series to clean up the Lustre tree. Other people have
>done some sparse and checkpatch cleanups, but I found a bunch of
>stuff building with W=1.

Hello Valdis,
thanks for these patches. Strictly speaking, they should also be sent
to "Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>" and also
devel@xxxxxxxxxxxxxxxxxxxx because Lustre is still in the staging tree.

Also, for the patch subject line, it is standard to use something like:

[PATCH 1/6] staging/lustre: Swap inline/const to kill 272 warnings

as generated by "git format-patch".

Could you please resubmit your patch series so that Greg sees your
patches.

Cheers, Andreas

>Valdis Kletnieks (6):
>
> Swap inline/const to kill 272 warnings
> Fix set-but-unused whinge.
> Clean up another C warnining:
> Fix another C compiler whine:
> Nuke an unsigned >= 0 assert
> Nuke another unsigned >= 0 assert
>
> drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 +
> drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
> drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 --
> drivers/staging/lustre/lustre/libcfs/module.c | 15 ++++----
> drivers/staging/lustre/lustre/llite/rw.c | 1 -
> drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 -
> 7 files changed, 26 insertions(+), 41 deletions(-)
>
>--
>2.6.3
>
>


Cheers, Andreas
--
Andreas Dilger

Lustre Principal Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/