Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

[Emil Velikov]

Hi Eric,

A couple of suggestions/requests on the UAPI header side

On 1 December 2015 at 20:35, Eric Anholt <eric@xxxxxxxxxx> wrote:

> --- /dev/null
> +++ b/include/uapi/drm/vc4_drm.h

> +#include <drm/drm.h>
> +
Can we make this a "drm.h" ?


> +struct drm_vc4_create_bo {
> +       uint32_t size;
> +       uint32_t flags;
> +       /** Returned GEM handle for the BO. */
> +       uint32_t handle;
> +       uint32_t pad;
... and not use the stdint.h types but __{s,u}* through the file.

I'd rather than not nag why we want/need those, but if you prefer I
can repeat myself/others.

Thanks
Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/