Re: [PATCH v2 0/3] Fixes for twl4030 charger

[Sebastian Reichel]

Hi Nikolaus,

On Mon, Nov 02, 2015 at 12:27:33PM +0100, H. Nikolaus Schaller wrote:
> Changes V2:
> * worked in comments by Nishanth Menon <nm@xxxxxx>
> * added another patch which solves a probing/boot stall problem (irq allocation vs. -EPROBE_DEFER)
> 
> V1:
> 4.3-rc1 introduced a new charger driver for the twl4030.
> 
> While making it operable and testing on GTA04 and OpenPandora
> we have found some issues.
> 
> 
> H. Nikolaus Schaller (3):
>   drivers:power:twl4030-charger: fix problem with EPROBE_DEFER
>   drivers:power:twl4030-charger: don't return after allocating irq
>   drivers:power:twl4030-charger: don't check if battery is present

PATCH 1 and 2 should be rebased to my current next branch.
They definetly do not take 2202e1fc5a into account. Also
take into account, that iio_channel_get() is not managed,
so you will have to free the channel, if your return an
error after it.

PATCH 3 introduces a new warning:

drivers/power/twl4030_charger.c:211:12: warning: âtwl4030_is_battery_presentâ defined but not used [-Wunused-function]

-- Sebastian

Attachment: signature.asc
Description: PGP signature