Re: [PATCH] fixdep: constify strrcmp arguments

From: Nicolas Iooss
Date: Sat Dec 05 2015 - 04:44:33 EST


Hello,
I sent the path below a few weeks ago and did not have any feedback.
Could you please review it?

Thanks,
Nicolas

On 11/18/2015 07:07 PM, Nicolas Iooss wrote:
> strrcmp only performs read access to the memory addressed by its
> arguments so make them const pointers.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
> ---
> scripts/basic/fixdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
> index c68fd61fdc42..5b327c67a828 100644
> --- a/scripts/basic/fixdep.c
> +++ b/scripts/basic/fixdep.c
> @@ -251,7 +251,7 @@ static void parse_config_file(const char *map, size_t len)
> }
>
> /* test is s ends in sub */
> -static int strrcmp(char *s, char *sub)
> +static int strrcmp(const char *s, const char *sub)
> {
> int slen = strlen(s);
> int sublen = strlen(sub);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/