Re: [PATCH] staging: speakup: kobjects.c: fix char argument to %02x

From: Joe Perches
Date: Sat Dec 05 2015 - 19:12:55 EST


On Sun, 2015-12-06 at 01:05 +0100, Rasmus Villemoes wrote:
> If char is signed and ch happens to be negative, printing ch with
> "%02x" will not do as intended (when ch is -19, one will get
> "ffffffed"). Fix that by masking with 0xff.

I presume there are a lot of these in the kernel.
Did you use a tool to find this or just inspection?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/