Re: [PATCH v2 1/2] um: Set secure access mode for temporary file

[MickaÃl SalaÃn]

On 06/12/2015 12:32, MickaÃl SalaÃn wrote:
> On 04/12/2015 18:13, Tristan Schmelcher wrote:
>> If there is a concern that the mkstemp implementation may be insecure,
>> why not set and restore the umask?
>>
> 
> I will add this safeguard.

Well, I'm concerned to use umask because it is not thread-safe and drivers may use create_mem_file() in a multi-theaded context. I prefer to stick to fchmod and handle the race-condition with O_TMPFILE unsell someone is sure that this will not create bugs :)

 MickaÃl

Attachment: signature.asc
Description: OpenPGP digital signature