Re: [PATCH 1/2] power: Fix unmet dependency on POWER_SUPPLY by POWER_RESET by uncoupling them

[Krzysztof Kozlowski]

On 05.12.2015 09:59, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Dec 02, 2015 at 02:59:06PM +0900, Krzysztof Kozlowski wrote:
>> Actually reset/power off handlers do not really depend on power supply.
>> Move the power reset out of power supply block so it will appear in main
>> drivers section. This fixes following build warning (encountered on ARM
>> exynos defconfig when POWER_SUPPLY is disabled manually):
>>
>> warning: (ARCH_HISI && ARCH_INTEGRATOR && ARCH_EXYNOS && ARCH_VEXPRESS && REALVIEW_DT) selects POWER_RESET which has unmet direct dependencies (POWER_SUPPLY)
>> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF)
>> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON_POWEROFF which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF)
> 
> nice catch. I don't really like the Makefile changes, though. I think
> it would be better to make the power/ entry in drivers/Makefile into
> "obj-y" and handle the details in drivers/power/Makefile.

You idea indeed looks better, I'll send a v2.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/