Re: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path

[Haggai Eran]

On Friday, December 4, 2015 8:02 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
> To: dledford@xxxxxxxxxx
> Cc: sean.hefty@xxxxxxxxx; hal.rosenstock@xxxxxxxxx; Haggai Eran; jgunthorpe@xxxxxxxxxxxxxxxxxxxx; Matan Barak; yun.wang@xxxxxxxxxxxxxxxx; ted.h.kim@xxxxxxxxxx; Doron Tsur; Erez Shitrit; david.ahern@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path
> 
> This adds a needed error path in the function, cm_init_av_by_path
> after the call to ib_init_ah_from_path in order to avoid incorrectly
> accessing the path pointer of structure type ib_sa_path_rec if this
> function call fails to complete its intended work successfully by
> returning a error code.
> 
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>

The subject doesn't seem to match the convention but apart from that,

Reviewed-by: Haggai Eran <haggaie@xxxxxxxxxxxx>

I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right?

Haggai--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/