Re: [PATCH 8/9] drm/vc4: Add support for async pageflips.

[Daniel Stone]

Hi,

On 4 December 2015 at 01:42, Eric Anholt <eric@xxxxxxxxxx> wrote:
> Daniel Stone <daniel@xxxxxxxxxxxxx> writes:
>> On 1 December 2015 at 20:35, Eric Anholt <eric@xxxxxxxxxx> wrote:
>>> An async pageflip stores the modeset to be done and executes it once
>>> the BOs are ready to be displayed.  This gets us about 3x performance
>>> in full screen rendering with pageflipping.
>>
>> Looks good, but you're missing a preclose callback to reap dead events, a la:
>> https://git.collabora.com/cgit/user/daniels/linux.git/commit/?h=wip/4.4.x/rockchip-drm-fixes&id=d14f21bcd7e7a1b9ca129c411a9da9c911037965
>>
>> (and parent commit to wire that through to core DRM preclose)
>
> We've already got a preclose callback that reaps crtc->event -- see
> vc4_cancel_page_flip().

Right you are. Carry on then. :)

Cheers,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/