Re: [PATCH] fbdev: sis: enforce selection of at least one backend

From: Tomi Valkeinen
Date: Mon Dec 07 2015 - 10:48:45 EST




On 27/11/15 16:33, Arnd Bergmann wrote:
> The sis framebuffer driver complains with a compile-time warning
> if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected:
>
> drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se
>
> This is reasonable because it doesn't work in that case, but it's
> also annoying for randconfig builds and is one of the most common
> warnings I'm seeing on ARM now.
>
> This changes the Kconfig logic to prevent the silly configuration,
> by always selecting the FB_SIS_300 variant if the other one is
> not set.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Sorry for sending this twice, it looks like I forgot the fbdev list and
> Tomi as recipients the first time

Thanks, queued for 4.5.

tomi

Attachment: signature.asc
Description: OpenPGP digital signature