Re: [PATCH] drm: msm: dsi: Added missing mutex_unlock

[Rob Clark]

On Sun, Dec 6, 2015 at 2:49 PM, Saurabh Sengar <saurabh.truth@xxxxxxxxx> wrote:
> in case of failed to get iova, function was returning without releasing
> the mutex. Added it.
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@xxxxxxxxx>

Reviewed-by: Rob Clark <robdclark@xxxxxxxxx>

> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 4c49868..13f937b 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
>         }
>
>         ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
> +       mutex_unlock(&dev->struct_mutex);
>         if (ret) {
>                 pr_err("%s: failed to get iova, %d\n", __func__, ret);
>                 return ret;
>         }
> -       mutex_unlock(&dev->struct_mutex);
>
>         if (iova & 0x07) {
>                 pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/