Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex ADJ_SETOFFSET to avoid overflow

From: John Stultz
Date: Mon Dec 07 2015 - 15:13:32 EST


On Mon, Dec 7, 2015 at 12:11 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 99188ee..a37222b 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -1986,6 +1986,7 @@ int do_adjtimex(struct timex *txc)
>
> if (txc->modes & ADJ_SETOFFSET) {
> struct timespec delta;
> +
> delta.tv_sec = txc->time.tv_sec;
> delta.tv_nsec = txc->time.tv_usec;
> if (!(txc->modes & ADJ_NANO))

Gah. Except for this needless whitespace. Ignore that please.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/