Re: [PATCH v2 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

[Nicolas Boichat]

On Thu, Nov 19, 2015 at 6:46 PM, Andrew-CT Chen
<andrew-ct.chen@xxxxxxxxxxxx> wrote:
> Add Mediatek EFUSE driver to access hardware data like
> thermal sensor calibration or HDMI impedance.
>
> Signed-off-by: Andrew-CT Chen <andrew-ct.chen@xxxxxxxxxxxx>
> ---
>  drivers/nvmem/Kconfig     | 11 ++++++
>  drivers/nvmem/Makefile    |  2 ++
>  drivers/nvmem/mtk-efuse.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 102 insertions(+)
>  create mode 100644 drivers/nvmem/mtk-efuse.c
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index bc4ea58..ea7ec17 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -36,6 +36,17 @@ config NVMEM_MXS_OCOTP
>           This driver can also be built as a module. If so, the module
>           will be called nvmem-mxs-ocotp.
>
> +config MTK_EFUSE

Nit: I think this entry should be between NVMEM_IMX_OCOTP and
NVMEM_MXS_OCOTP (looks like NVMEM_ prefix is ignored in the ordering).

> [snip]

The rest looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/