Re: [PATCH v4 3/8] ARM: dts: Exynos5420: add CPU OPP properties

From: Krzysztof Kozlowski
Date: Tue Dec 08 2015 - 02:17:57 EST

On 08.12.2015 03:18, Bartlomiej Zolnierkiewicz wrote:
> From: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
>
> For Exynos5420 platforms, add CPU operating points for
> migrating from Exynos specific cpufreq driver to using
> generic cpufreq driver.
>
> Changes by Bartlomiej:
> - split Exynos5420 support from the original patch
>
> Changes by Ben Gamari:
> - Port to operating-points-v2
>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
> Cc: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> Cc: Andreas Faerber <afaerber@xxxxxxx>
> Cc: Sachin Kamat <sachin.kamat@xxxxxxxxxx>

Sachin's address does not work neither.

> Cc: Thomas Abraham <thomas.ab@xxxxxxxxxxx>

Thomas' SoB disappeared.

I see that you directly re-used Thomas' values for voltages and
frequencies. For Exynos5420 we could go down to 200 MHz (for both cores)
but this can be fine-tuned per-board later.

Best regards,
Krzysztof


> Signed-off-by: Ben Gamari <ben@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 122 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 122 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 48a0a55..f8f70a5 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -50,6 +50,116 @@
> usbdrdphy1 = &usbdrd_phy1;
> };
>
> + cpu0_opp_table: opp_table0 {
> + compatible = "operating-points-v2";
> + opp-shared;
> + opp00@1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp01@1700000000 {
> + opp-hz = /bits/ 64 <1700000000>;
> + opp-microvolt = <1212500>;
> + clock-latency-ns = <140000>;
> + };
> + opp02@1600000000 {
> + opp-hz = /bits/ 64 <1600000000>;
> + opp-microvolt = <1175000>;
> + clock-latency-ns = <140000>;
> + };
> + opp03@1500000000 {
> + opp-hz = /bits/ 64 <1500000000>;
> + opp-microvolt = <1137500>;
> + clock-latency-ns = <140000>;
> + };
> + opp04@1400000000 {
> + opp-hz = /bits/ 64 <1400000000>;
> + opp-microvolt = <1112500>;
> + clock-latency-ns = <140000>;
> + };
> + opp05@1300000000 {
> + opp-hz = /bits/ 64 <1300000000>;
> + opp-microvolt = <1062500>;
> + clock-latency-ns = <140000>;
> + };
> + opp06@1200000000 {
> + opp-hz = /bits/ 64 <1200000000>;
> + opp-microvolt = <1037500>;
> + clock-latency-ns = <140000>;
> + };
> + opp07@1100000000 {
> + opp-hz = /bits/ 64 <1100000000>;
> + opp-microvolt = <1012500>;
> + clock-latency-ns = <140000>;
> + };
> + opp08@1000000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = < 987500>;
> + clock-latency-ns = <140000>;
> + };
> + opp09@900000000 {
> + opp-hz = /bits/ 64 <900000000>;
> + opp-microvolt = < 962500>;
> + clock-latency-ns = <140000>;
> + };
> + opp10@800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = < 937500>;
> + clock-latency-ns = <140000>;
> + };
> + opp11@700000000 {
> + opp-hz = /bits/ 64 <700000000>;
> + opp-microvolt = < 912500>;
> + clock-latency-ns = <140000>;
> + };
> + };
> +
> + cpu1_opp_table: opp_table1 {
> + compatible = "operating-points-v2";
> + opp-shared;
> + opp00@1300000000 {
> + opp-hz = /bits/ 64 <1300000000>;
> + opp-microvolt = <1275000>;
> + clock-latency-ns = <140000>;
> + };
> + opp01@1200000000 {
> + opp-hz = /bits/ 64 <1200000000>;
> + opp-microvolt = <1212500>;
> + clock-latency-ns = <140000>;
> + };
> + opp02@1100000000 {
> + opp-hz = /bits/ 64 <1100000000>;
> + opp-microvolt = <1162500>;
> + clock-latency-ns = <140000>;
> + };
> + opp03@1000000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = <1112500>;
> + clock-latency-ns = <140000>;
> + };
> + opp04@900000000 {
> + opp-hz = /bits/ 64 <900000000>;
> + opp-microvolt = <1062500>;
> + clock-latency-ns = <140000>;
> + };
> + opp05@800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <1025000>;
> + clock-latency-ns = <140000>;
> + };
> + opp06@700000000 {
> + opp-hz = /bits/ 64 <700000000>;
> + opp-microvolt = <975000>;
> + clock-latency-ns = <140000>;
> + };
> + opp07@600000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-microvolt = <937500>;
> + clock-latency-ns = <140000>;
> + };
> + };
> +
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -58,8 +168,11 @@
> device_type = "cpu";
> compatible = "arm,cortex-a15";
> reg = <0x0>;
> + clocks = <&clock CLK_ARM_CLK>;
> + clock-names = "cpu-cluster.0";
> clock-frequency = <1800000000>;
> cci-control-port = <&cci_control1>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu1: cpu@1 {
> @@ -68,6 +181,7 @@
> reg = <0x1>;
> clock-frequency = <1800000000>;
> cci-control-port = <&cci_control1>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu2: cpu@2 {
> @@ -76,6 +190,7 @@
> reg = <0x2>;
> clock-frequency = <1800000000>;
> cci-control-port = <&cci_control1>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu3: cpu@3 {
> @@ -84,14 +199,18 @@
> reg = <0x3>;
> clock-frequency = <1800000000>;
> cci-control-port = <&cci_control1>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu4: cpu@100 {
> device_type = "cpu";
> compatible = "arm,cortex-a7";
> reg = <0x100>;
> + clocks = <&clock CLK_KFC_CLK>;
> + clock-names = "cpu-cluster.1";
> clock-frequency = <1000000000>;
> cci-control-port = <&cci_control0>;
> + operating-points-v2 = <&cpu1_opp_table>;
> };
>
> cpu5: cpu@101 {
> @@ -100,6 +219,7 @@
> reg = <0x101>;
> clock-frequency = <1000000000>;
> cci-control-port = <&cci_control0>;
> + operating-points-v2 = <&cpu1_opp_table>;
> };
>
> cpu6: cpu@102 {
> @@ -108,6 +228,7 @@
> reg = <0x102>;
> clock-frequency = <1000000000>;
> cci-control-port = <&cci_control0>;
> + operating-points-v2 = <&cpu1_opp_table>;
> };
>
> cpu7: cpu@103 {
> @@ -116,6 +237,7 @@
> reg = <0x103>;
> clock-frequency = <1000000000>;
> cci-control-port = <&cci_control0>;
> + operating-points-v2 = <&cpu1_opp_table>;
> };
> };
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/