Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

[Peter Zijlstra]

On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote:
> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void)
>  		break;
>  	case 61: /* Broadwell */
>  		ret = bdw_uncore_pci_init();
> +	case 87: /* Knights Landing */
> +		ret = knl_uncore_pci_init();
>  		break;
>  	default:
>  		return 0;
> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void)
>  		break;
>  	case 86: /* BDX-DE */
>  		bdx_uncore_cpu_init();
> +	case 87: /* Knights Landing */
> +		knl_uncore_cpu_init();
>  		break;
>  	default:

Surely you need some extra break statements in there?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/