RE: [v9, 3/6] fsl/fman: Add FMan MAC support

[Liberman Igal]

Regards,
Igal Liberman

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Thursday, December 03, 2015 10:24 PM
> To: Liberman Igal-B31950 <Igal.Liberman@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Wood Scott-B07421 <scottwood@xxxxxxxxxxxxx>;
> Bucur Madalin-Cristian-B32716 <madalin.bucur@xxxxxxxxxxxxx>;
> pebolle@xxxxxxxxxx; joakim.tjernlund@xxxxxxxxxxxx; ppc@xxxxxxxxxxxxxxx;
> stephen@xxxxxxxxxxxxxxxxxx
> Subject: Re: [v9, 3/6] fsl/fman: Add FMan MAC support
> 
> From: <igal.liberman@xxxxxxxxxxxxx>
> Date: Thu, 3 Dec 2015 09:19:14 +0200
> 
> > +static u32 crc_table[256] = {
> 
> No way.
> 
> We have every conceivable implementation of CRC calculations in the kernel
> already.  Use them.

OK, I will remove the private implementation of CRC calculation in the next submission. Thank you.

Igal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/