Re: [PATCH 00/13] perf tools: Move perf subcommand framework into lib/tools

[Arnaldo Carvalho de Melo]

Em Mon, Dec 07, 2015 at 09:46:48AM +0100, Jiri Olsa escreveu:
> On Sun, Dec 06, 2015 at 02:02:42PM -0600, Josh Poimboeuf wrote:
> > On Sun, Dec 06, 2015 at 04:50:06PM +0100, Jiri Olsa wrote:
> > > On Sun, Dec 06, 2015 at 10:37:52AM +0100, Ingo Molnar wrote:
> > > > 
> > > > * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > > > 
> > > > > Ingo suggested that I factor out the perf subcommand functionality
> > > > > (originally copied from git) into tools/lib so that it can be used by
> > > > > stacktool[*] and possibly others.
> > > > > 
> > > > > All the subcommand option handling files have been moved into libapi,
> > > > > including parse-options.c, run-command.c, exec_cmd.c, help.c, usage.c,
> > > > > and their dependencies.  Since several of the dependencies are more
> > > > > general-purpose "utilities" which aren't directly related to
> > > > > subcommands, I put everything in 'tools/lib/api/util'.  They're linked
> > > > > into perf as part of the libapi.a library.
> > > > > 
> > > > > Patches 1-10 do some cleanups and splitting up of the code in
> > > > > preparation for the move.
> > > > > 
> > > > > Patch 11 does the actual moving of the files into tools/lib/api/util.
> > > > > 
> > > > > [*] https://lkml.kernel.org/r/cover.1445443144.git.jpoimboe@xxxxxxxxxx
> > > > > 
> > > > > Josh Poimboeuf (13):
> > > > >   perf: Use -iquote for local include paths
> > > > >   perf: Split up util.h
> > > > >   perf: Move term functions out of util.c
> > > > >   perf: Remove unused pager_use_color variable
> > > > >   perf: Split up cache.h
> > > > >   perf: Remove cache.h
> > > > >   perf: Save cmdline arguments earlier
> > > > >   perf: Remove check for unused PERF_PAGER_IN_USE
> > > > >   perf: Move cmd_version() to builtin-version.c
> > > > >   perf: Move help_unknown_cmd() to its own file
> > > > >   perf tools: Move strlcpy() to tools/lib/string.c
> > > > >   perf tools: Move perf subcommand framework into a library
> > > > >   perf tools: Move subcommand framework and related utils to libapi
> > > > 
> > > > >  133 files changed, 852 insertions(+), 761 deletions(-)
> > > > 
> > > > So this split-out looks great to me!
> > > > 
> > > > A bit of a background: this series is a necessary precondition of me being able to 
> > > > merge 'stacktool' and the frame pointer handling enhancements Josh is working on - 
> > > > but it would be nice if this could all be done via Arnaldo's perf tree to minimize 
> > > > any impact on pending perf work.
> > > > 
> > > > I've Cc:-ed Namhyung and Jiri as well, who've done a lot of work in perf/util/.
> > > > 
> > > 
> > > heya,
> > > got compilation error over this patchset:
> > > 
> > > [jolsa@krava perf]$ make clean && make JOBS=1
> > > 
> > >   ...
> > > 
> > >   CC       tests/llvm-src-base.o
> > > tests/llvm-src-base.c:1:24: fatal error: tests/llvm.h: No such file or directory
> > > compilation terminated.
> > > mv: cannot stat âtests/.llvm-src-base.o.tmpâ: No such file or directory
> > > /home/jolsa/kernel/linux-perf/tools/build/Makefile.build:77: recipe for target 'tests/llvm-src-base.o' failed
> > > make[3]: *** [tests/llvm-src-base.o] Error 1
> > > /home/jolsa/kernel/linux-perf/tools/build/Makefile.build:116: recipe for target 'tests' failed
> > > make[2]: *** [tests] Error 2
> > > Makefile.perf:313: recipe for target 'perf-in.o' failed
> > > make[1]: *** [perf-in.o] Error 2
> > > Makefile:68: recipe for target 'all' failed
> > > make: *** [all] Error 2
> > 
> > I think the problem is that you have a stale version of the
> > auto-generated file llvm-src-base.c.  Looks like "make clean" doesn't
> > remove it.  I'll add a patch to fix it.
> 
> FYI I switched back to Arnaldo's perf/core and did 'make clean && make'
> which passed, then switched back to your change and build failed again

Even after his patches, it doesn't work, but I think this time he is not
taking $(OUTPUT) into account, and as I do use "O=/tmp/build/perf/" it
fails, trying to fix this...

- Arnaldo

Applying: perf: Use -iquote for local include paths
[perf/core dbb37aec117a] perf tools: Use -iquote for local include paths
 Author: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
 Date: Mon Dec 7 22:21:40 2015 -0600
 5 files changed, 11 insertions(+), 11 deletions(-)
[acme@zoo linux]$ m
make: Entering directory '/home/git/linux/tools/perf'
  BUILD:   Doing 'make -j4' parallel build
  CC       /tmp/build/perf/builtin-bench.o
  CC       /tmp/build/perf/util/abspath.o
  CC       /tmp/build/perf/util/alias.o
  CC       /tmp/build/perf/builtin-annotate.o
  CC       /tmp/build/perf/builtin-config.o
  CC       /tmp/build/perf/util/annotate.o
  CC       /tmp/build/perf/ui/gtk/browser.o
  CC       /tmp/build/perf/util/build-id.o
  CC       /tmp/build/perf/builtin-diff.o
  CC       /tmp/build/perf/util/config.o
  CC       /tmp/build/perf/ui/gtk/hists.o
  CC       /tmp/build/perf/util/ctype.o
  CC       /tmp/build/perf/ui/gtk/setup.o
  CC       /tmp/build/perf/builtin-evlist.o
  CC       /tmp/build/perf/ui/gtk/util.o
  CC       /tmp/build/perf/util/db-export.o
  CC       /tmp/build/perf/util/env.o
  CC       /tmp/build/perf/ui/gtk/helpline.o
  CC       /tmp/build/perf/builtin-help.o
  CC       /tmp/build/perf/ui/gtk/progress.o
  CC       /tmp/build/perf/builtin-sched.o
  CC       /tmp/build/perf/ui/gtk/annotate.o
  CC       /tmp/build/perf/util/environment.o
  CC       /tmp/build/perf/util/event.o
  CC       /tmp/build/perf/builtin-buildid-list.o
  LD       /tmp/build/perf/ui/gtk/gtk-in.o
  CC       /tmp/build/perf/builtin-buildid-cache.o
  CC       /tmp/build/perf/util/evlist.o
  LD       /tmp/build/perf/gtk-in.o
  CC       /tmp/build/perf/util/evsel.o
  CC       /tmp/build/perf/util/exec_cmd.o
  CC       /tmp/build/perf/arch/common.o
  CC       /tmp/build/perf/arch/x86/util/header.o
  CC       /tmp/build/perf/util/find_next_bit.o
  CC       /tmp/build/perf/arch/x86/util/tsc.o
  CC       /tmp/build/perf/arch/x86/util/pmu.o
  CC       /tmp/build/perf/builtin-list.o
  CC       /tmp/build/perf/util/help.o
  CC       /tmp/build/perf/arch/x86/util/kvm-stat.o
  CC       /tmp/build/perf/builtin-record.o
  CC       /tmp/build/perf/util/kallsyms.o
  CC       /tmp/build/perf/util/levenshtein.o
  CC       /tmp/build/perf/builtin-report.o
  CC       /tmp/build/perf/builtin-stat.o
  CC       /tmp/build/perf/util/llvm-utils.o
  CC       /tmp/build/perf/util/parse-options.o
  CC       /tmp/build/perf/arch/x86/util/perf_regs.o
  CC       /tmp/build/perf/builtin-timechart.o
  CC       /tmp/build/perf/arch/x86/tests/regs_load.o
  CC       /tmp/build/perf/arch/x86/util/dwarf-regs.o
  CC       /tmp/build/perf/builtin-top.o
  CC       /tmp/build/perf/arch/x86/tests/dwarf-unwind.o
  CC       /tmp/build/perf/util/parse-events.o
  CC       /tmp/build/perf/arch/x86/util/unwind-libunwind.o
  CC       /tmp/build/perf/arch/x86/tests/arch-tests.o
  CC       /tmp/build/perf/util/perf_regs.o
  CC       /tmp/build/perf/builtin-script.o
  CC       /tmp/build/perf/arch/x86/util/auxtrace.o
  CC       /tmp/build/perf/builtin-kmem.o
  CC       /tmp/build/perf/arch/x86/tests/rdpmc.o
  CC       /tmp/build/perf/arch/x86/util/intel-pt.o
  CC       /tmp/build/perf/util/path.o
  CC       /tmp/build/perf/arch/x86/tests/perf-time-to-tsc.o
  CC       /tmp/build/perf/builtin-lock.o
  CC       /tmp/build/perf/util/rbtree.o
  CC       /tmp/build/perf/arch/x86/util/intel-bts.o
  CC       /tmp/build/perf/arch/x86/tests/insn-x86.o
  CC       /tmp/build/perf/util/libstring.o
  LD       /tmp/build/perf/arch/x86/util/libperf-in.o
  CC       /tmp/build/perf/util/bitmap.o
  CC       /tmp/build/perf/builtin-kvm.o
  CC       /tmp/build/perf/arch/x86/tests/intel-cqm.o
  CC       /tmp/build/perf/util/hweight.o
  CC       /tmp/build/perf/builtin-inject.o
  CC       /tmp/build/perf/builtin-mem.o
  CC       /tmp/build/perf/ui/setup.o
  LD       /tmp/build/perf/arch/x86/tests/libperf-in.o
  LD       /tmp/build/perf/arch/x86/libperf-in.o
  LD       /tmp/build/perf/arch/libperf-in.o
  CC       /tmp/build/perf/util/run-command.o
  CC       /tmp/build/perf/builtin-data.o
  CC       /tmp/build/perf/ui/helpline.o
  CC       /tmp/build/perf/ui/progress.o
  CC       /tmp/build/perf/util/quote.o
  CC       /tmp/build/perf/scripts/perl/Perf-Trace-Util/Context.o
  CC       /tmp/build/perf/util/strbuf.o
  LD       /tmp/build/perf/scripts/perl/Perf-Trace-Util/libperf-in.o
  CC       /tmp/build/perf/scripts/python/Perf-Trace-Util/Context.o
  CC       /tmp/build/perf/ui/util.o
  CC       /tmp/build/perf/util/string.o
  CC       /tmp/build/perf/builtin-trace.o
  LD       /tmp/build/perf/scripts/python/Perf-Trace-Util/libperf-in.o
  LD       /tmp/build/perf/scripts/libperf-in.o
  CC       /tmp/build/perf/builtin-probe.o
  CC       /tmp/build/perf/ui/hist.o
  CC       /tmp/build/perf/util/strlist.o
  CC       /tmp/build/perf/ui/stdio/hist.o
  CC       /tmp/build/perf/bench/sched-messaging.o
  CC       /tmp/build/perf/util/strfilter.o
  CC       /tmp/build/perf/util/top.o
  CC       /tmp/build/perf/ui/browser.o
  CC       /tmp/build/perf/bench/sched-pipe.o
  CC       /tmp/build/perf/bench/mem-functions.o
  CC       /tmp/build/perf/ui/browsers/annotate.o
  CC       /tmp/build/perf/bench/futex-hash.o
  CC       /tmp/build/perf/ui/browsers/hists.o
  CC       /tmp/build/perf/util/usage.o
  CC       /tmp/build/perf/ui/tui/setup.o
  CC       /tmp/build/perf/ui/browsers/map.o
  CC       /tmp/build/perf/bench/futex-wake.o
  CC       /tmp/build/perf/util/wrapper.o
  CC       /tmp/build/perf/ui/tui/util.o
  CC       /tmp/build/perf/ui/browsers/scripts.o
  CC       /tmp/build/perf/util/sigchain.o
  CC       /tmp/build/perf/ui/tui/helpline.o
  CC       /tmp/build/perf/bench/futex-wake-parallel.o
  CC       /tmp/build/perf/util/dso.o
  CC       /tmp/build/perf/ui/browsers/header.o
  CC       /tmp/build/perf/bench/futex-requeue.o
  CC       /tmp/build/perf/ui/tui/progress.o
  CC       /tmp/build/perf/bench/futex-lock-pi.o
  LD       /tmp/build/perf/ui/browsers/libperf-in.o
  CC       /tmp/build/perf/bench/mem-memcpy-x86-64-asm.o
  CC       /tmp/build/perf/util/symbol.o
  CC       /tmp/build/perf/util/color.o
  LD       /tmp/build/perf/ui/tui/libperf-in.o
  LD       /tmp/build/perf/ui/libperf-in.o
  CC       /tmp/build/perf/util/pager.o
  CC       /tmp/build/perf/bench/mem-memset-x86-64-asm.o
  CC       /tmp/build/perf/tests/builtin-test.o
  CC       /tmp/build/perf/tests/parse-events.o
  CC       /tmp/build/perf/util/header.o
  CC       /tmp/build/perf/tests/dso-data.o
  CC       /tmp/build/perf/util/callchain.o
  CC       /tmp/build/perf/bench/numa.o
  CC       /tmp/build/perf/perf.o
  CC       /tmp/build/perf/tests/attr.o
  CC       /tmp/build/perf/tests/vmlinux-kallsyms.o
  LD       /tmp/build/perf/bench/perf-in.o
  CC       /tmp/build/perf/tests/openat-syscall.o
  CC       /tmp/build/perf/util/values.o
  CC       /tmp/build/perf/tests/openat-syscall-all-cpus.o
  CC       /tmp/build/perf/util/debug.o
  CC       /tmp/build/perf/util/machine.o
  CC       /tmp/build/perf/tests/openat-syscall-tp-fields.o
  CC       /tmp/build/perf/tests/mmap-basic.o
  CC       /tmp/build/perf/tests/perf-record.o
  CC       /tmp/build/perf/util/map.o
  CC       /tmp/build/perf/util/pstack.o
  CC       /tmp/build/perf/tests/evsel-roundtrip-name.o
  CC       /tmp/build/perf/tests/evsel-tp-sched.o
  CC       /tmp/build/perf/tests/fdarray.o
  CC       /tmp/build/perf/util/session.o
  CC       /tmp/build/perf/tests/pmu.o
  CC       /tmp/build/perf/util/ordered-events.o
  CC       /tmp/build/perf/util/comm.o
  CC       /tmp/build/perf/util/thread.o
  CC       /tmp/build/perf/tests/hists_common.o
  CC       /tmp/build/perf/tests/hists_link.o
  CC       /tmp/build/perf/tests/hists_filter.o
  CC       /tmp/build/perf/tests/hists_output.o
  CC       /tmp/build/perf/util/thread_map.o
  CC       /tmp/build/perf/tests/hists_cumulate.o
  CC       /tmp/build/perf/tests/python-use.o
  CC       /tmp/build/perf/util/trace-event-parse.o
  CC       /tmp/build/perf/util/parse-events-flex.o
  CC       /tmp/build/perf/util/parse-events-bison.o
  CC       /tmp/build/perf/tests/bp_signal.o
  CC       /tmp/build/perf/tests/bp_signal_overflow.o
  CC       /tmp/build/perf/util/pmu.o
  CC       /tmp/build/perf/util/pmu-flex.o
  CC       /tmp/build/perf/tests/task-exit.o
  CC       /tmp/build/perf/tests/sw-clock.o
  CC       /tmp/build/perf/util/pmu-bison.o
  CC       /tmp/build/perf/tests/mmap-thread-lookup.o
  CC       /tmp/build/perf/tests/thread-mg-share.o
  CC       /tmp/build/perf/tests/switch-tracking.o
  CC       /tmp/build/perf/util/trace-event-read.o
  CC       /tmp/build/perf/util/trace-event-info.o
  CC       /tmp/build/perf/util/trace-event-scripting.o
  CC       /tmp/build/perf/tests/keep-tracking.o
  CC       /tmp/build/perf/util/trace-event.o
  CC       /tmp/build/perf/tests/code-reading.o
  CC       /tmp/build/perf/util/svghelper.o
  CC       /tmp/build/perf/util/sort.o
  CC       /tmp/build/perf/tests/sample-parsing.o
  CC       /tmp/build/perf/tests/parse-no-sample-id-all.o
  CC       /tmp/build/perf/util/hist.o
  CC       /tmp/build/perf/tests/kmod-path.o
  CC       /tmp/build/perf/util/util.o
  CC       /tmp/build/perf/util/xyarray.o
  CC       /tmp/build/perf/tests/thread-map.o
  CC       /tmp/build/perf/tests/llvm.o
  CC       /tmp/build/perf/util/cpumap.o
  CC       /tmp/build/perf/util/cgroup.o
  CC       /tmp/build/perf/tests/llvm-src-base.o
  CC       /tmp/build/perf/tests/llvm-src-kbuild.o
  CC       /tmp/build/perf/util/target.o
  CC       /tmp/build/perf/util/rblist.o
  CC       /tmp/build/perf/util/intlist.o
/tmp/build/perf/tests/llvm-src-kbuild.c:1:24: fatal error: tests/llvm.h:
No such file or directory
 #include <tests/llvm.h>
                        ^
compilation terminated.
mv: cannot stat â/tmp/build/perf/tests/.llvm-src-kbuild.o.tmpâ: No such
file or directory
/home/git/linux/tools/build/Makefile.build:77: recipe for target
'/tmp/build/perf/tests/llvm-src-kbuild.o' failed
make[3]: *** [/tmp/build/perf/tests/llvm-src-kbuild.o] Error 1
make[3]: *** Waiting for unfinished jobs....
  CC       /tmp/build/perf/util/vdso.o
  CC       /tmp/build/perf/util/counts.o
  CC       /tmp/build/perf/util/stat.o
/tmp/build/perf/tests/llvm-src-base.c:1:24: fatal error: tests/llvm.h:
No such file or directory
 #include <tests/llvm.h>
                        ^
compilation terminated.
mv: cannot stat â/tmp/build/perf/tests/.llvm-src-base.o.tmpâ: No such
file or directory
/home/git/linux/tools/build/Makefile.build:77: recipe for target
'/tmp/build/perf/tests/llvm-src-base.o' failed
make[3]: *** [/tmp/build/perf/tests/llvm-src-base.o] Error 1
/home/git/linux/tools/build/Makefile.build:116: recipe for target
'tests' failed
make[2]: *** [tests] Error 2
Makefile.perf:313: recipe for target '/tmp/build/perf/perf-in.o' failed
make[1]: *** [/tmp/build/perf/perf-in.o] Error 2
make[1]: *** Waiting for unfinished jobs....
  CC       /tmp/build/perf/util/stat-shadow.o

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/