RE: [PATCH] mfd: da9063: Allow modular build

[Opensource [Steve Twiss]]

On 08 December 2015 @ 13:56 Lee Jones wrote:

> To: Geert Uytterhoeven
> Cc: Support Opensource; Liam Girdwood; Mark Brown; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] mfd: da9063: Allow modular build
> 
> On Mon, 07 Dec 2015, Geert Uytterhoeven wrote:
> 
> > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which
> > allows to decrease size of multi-platform kernels (e.g.
> > multi_v7_defconfig).
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> The DA9063 driver appears to contain all module code.  In fact, I'm
> surprised that it wasn't enabled for tristate in the first place.
> 
> In any case, it would be good to get a Reviewed/Acked-by from one of
> the Dialog guys.
> 

Hi Lee; Geert,
I'll take a look at this.
Regards,
Steve

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 4d92df6ef9fe92ac..527ee7168617c933 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -211,7 +211,7 @@ config MFD_DA9062
> >  	  of the device.
> >
> >  config MFD_DA9063
> > -	bool "Dialog Semiconductor DA9063 PMIC Support"
> > +	tristate "Dialog Semiconductor DA9063 PMIC Support"
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> >  	select REGMAP_IRQ