Re: [PATCH] regmap: speed up the regcache_init()

From: Mark Brown
Date: Tue Dec 08 2015 - 12:05:34 EST


On Thu, Dec 03, 2015 at 10:19:10AM +0800, Xiubo Li wrote:

> If the cache is not used by the device driver, there is not need to
> check the striding of the registers. It will just return 0 from
> regcache_init() and let the register striding be checked in proper
> place when needed.

> - for (i = 0; i < config->num_reg_defaults; i++)
> - if (config->reg_defaults[i].reg % map->reg_stride)
> - return -EINVAL;
> -
> if (map->cache_type == REGCACHE_NONE) {
> map->cache_bypass = true;
> return 0;
> }

If we're not using the register cache why are there defaults in the
first place?

Attachment: signature.asc
Description: PGP signature