Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

[Josh Poimboeuf]

On Tue, Dec 08, 2015 at 04:09:31PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 08, 2015 at 12:49:53PM -0600, Josh Poimboeuf escreveu:
> > On Tue, Dec 08, 2015 at 07:16:26PM +0100, Jiri Olsa wrote:
> > > On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote:
> > > > The perf subcommand framework is needed for other tools.  Move
> > > > parse-options.c and its dependencies over to libapi.
> > > > 
> > > > Any function names with 'perf' have been renamed to something more
> > > > generic.
> > > > 
> > > > Also created a util_cfg struct for passing perf-specific configuration
> > > > to the library.  Specifying the configuration at runtime allows the same
> > > > binary to be shared by multiple tools without having to recompile it.
> > > 
> > > this patch is too big.. IMO it needs to be split into 3 parts
> > > as described in above 3 paragraphs
> > 
> > Ok, will do.
> 
> Also please rename this util_cfg struct to something more expressive,
> breaking down the patch may help in finding a better name, I guess.

I'm certainly open to doing so, but I'm having trouble coming up with a
better name.  The current name makes sense to me, because the struct
contains various configuration options needed by the libapi "util" code.

Would 'libapi_util_config' be better?  Or do you have any other
suggestions?

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/