Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy

[Yakir Yang]

Hi Rob

On 12/08/2015 11:06 PM, Rob Herring wrote:
> On Mon, Dec 07, 2015 at 02:39:50PM +0800, Yakir Yang wrote:
> > Add dt binding documentation for rockchip display port PHY.
> >
> > Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx>
> > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> One possible typo below, otherwise:
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Thanks, it's a typo :)

> > ---
> > Changes in v10: None
> > Changes in v9: None
> > Changes in v8:
> > - Remove the specific address in the example node name. (Heiko)
> >
> > Changes in v7:
> > - Simplify the commit message. (Kishon)
> >
> > Changes in v6: None
> > Changes in v5:
> > - Split binding doc's from driver changes. (Rob)
> > - Update the rockchip,grf explain in document, and correct the clock required
> >    elemets in document. (Rob & Heiko)
> >
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> >
> >   .../devicetree/bindings/phy/rockchip-dp-phy.txt    | 22 ++++++++++++++++++++++
> >   1 file changed, 22 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
> >
> > diff --git a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
> > new file mode 100644
> > index 0000000..00902cb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
> > @@ -0,0 +1,22 @@
> > +Rockchip Soc Seroes Display Port PHY
>                     ^
> Is this supposed to be SerDes?

Hmmm... it shouldn't be SerDes, i guess i may want 'series' which copy 
from samsung-phy.txt.

Thanks for catch that, for now i think it should be "Rockchip specific 
extensions to the Analogix Display Port PHY". I would send the v10.1 to 
fix this typo :)

Thanks,
- Yakir

> > +------------------------------------
> > +
> > +Required properties:
> > +- compatible : should be one of the following supported values:
> > +	 - "rockchip.rk3288-dp-phy"
> > +- clocks: from common clock binding: handle to dp clock.
> > +	of memory mapped region.
> > +- clock-names: from common clock binding:
> > +	Required elements: "24m"
> > +- rockchip,grf: phandle to the syscon managing the "general register files"
> > +- #phy-cells : from the generic PHY bindings, must be 0;
> > +
> > +Example:
> > +
> > +edp_phy: edp-phy {
> > +	compatible = "rockchip,rk3288-dp-phy";
> > +	rockchip,grf = <&grf>;
> > +	clocks = <&cru SCLK_EDP_24M>;
> > +	clock-names = "24m";
> > +	#phy-cells = <0>;
> > +};
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/