Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck warnings

[Xiubo Li]

On 09/12/2015 01:12, Mark Brown wrote:
> On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:
>
> > There will be some warning like the following when checking new
> > patches near this code:
> >      "WARNING: Missing a blank line after declarations"
> > This patch will suppress this warning.
> >   	switch (map->cache_word_size) {
> > -	case 1: {
> > -		u8 *cache = base;
> > -		cache[idx] = val;
> > +	case 1:
> > +		((u8 *)base)[idx] = val;
> >   		break;
> > -	}
> If there's a change to shut checkpatch up I'd rather just add the blank
> line it's asking for - the code is the way it is currently to avoid the
> casts since they're hard for people to read.
Both of them are okay for me.

I will send the v2 for these just adding one blank line.

Thanks,

BRs

Xiubo





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/