Re: [tip:locking/core] sched/wait: Fix signal handling in bit wait helpers

[Peter Zijlstra]

On Wed, Dec 09, 2015 at 12:06:33PM +1100, NeilBrown wrote:
> On Tue, Dec 08 2015, Peter Zijlstra wrote:
> 
> >>  
> >
> > *sigh*, so that patch was broken.. the below might fix it, but please
> > someone look at it, I seem to have a less than stellar track record
> > here...
> 
> This new change seems to be more intrusive than should be needed.
> Can't we just do:
> 
> 
>  __sched int bit_wait(struct wait_bit_key *word)
>  {
> +	long state = current->state;

No, current->state can already be changed by this time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/