Re: [PATCH v2 1/3] dt-binding: power: Add otg regulator binding

[Rob Herring]

On Wed, Dec 9, 2015 at 6:55 AM, Tim Bird <tim.bird@xxxxxxxxxxxxxx> wrote:
> On 12/08/2015 08:11 PM, Rob Herring wrote:
>> On Tue, Dec 08, 2015 at 04:40:16PM -0800, Tim Bird wrote:
>>> Add a binding for the regulator which controls the OTG chargepath switch.
>>> The OTG switch gets its power from pm8941_5vs1, and that should be
>>> expressed as a usb-otg-in-supply property in the DT node for the
>>> charger driver.  The regulator name is "otg".

[...]

>>> +child nodes:
>>> +- otg:
>>> +  Usage: optional
>>> +  Description: This node defines a regulator used to control the direction
>>> +               of VBUS voltage - specifically: whether to supply voltage
>>> +               to VBUS for host mode operation of the OTG port, or allow
>>> +               input voltage from external VBUS for charging.  In the
>>> +               hardware, the supply for this regulator comes from
>>> +               usb-otg-in-supply.
>>
>> Doesn't this regulator need to have a name defined?
>
> I'm not sure what you mean.  The regulator name is "otg", defined by the DT node
> name. The code requires that the DT node name be "otg", and defines a regulator
> with the same name.
>
> As far as I know, you have to define a DT label for the node, in order
> to reference this regulator with a phandle.  Is that what you are referring to?
> I usually use "chg_otg" as the label.  Are you asking that this be reflected
> in the example?

You need a regulator-name property. Also, should should define valid
values for regulator-min-microvolt and regulator-max-microvolt.

Thinking about this some more, the node name should be generic, so
just "regulator". The label does not need to be generic.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/