Re: [PATCH 01/12] selftests/x86: Extend Makefile to allow 64-bit only tests

From: Shuah Khan
Date: Wed Dec 09 2015 - 14:58:18 EST


On Wed, Dec 9, 2015 at 12:22 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
> On Wed, Dec 9, 2015 at 11:11 AM, Shuah Khan <shuahkhan@xxxxxxxxx> wrote:
>> On Mon, Dec 7, 2015 at 2:51 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>>> There aren't any yet, but there might be a few some day.
>>
>> Andy,
>>
>> Hmm. I would think get_maintainer script should have included
>> linux-api and as well as my email for this patch.
>
> Whoops, my bad.
>
> Although... isn't it about time that selftests got its own list?
>

I probably should do that.

>>
>> Anyway, I would like to see a better worded changelog.
>> Something along the lines
>>
>> Makefile changes to enable x86_64 tests.
>
> I find that confusing. The Makefile already supports x86_64 tests.
> What's missing is support for tests that are x86_64 but not x86_32.
>

Right. Exactly why I asked you to make the change log better.
You could hrase what you just told me and that would help me
understand the change better. Something along the lines:

Change Makefille to add support for x86_64 tests that don't
run on x86_32.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/