Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

[Andrew Morton]

On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote:
> > On Wed,____9 Dec 2015 13:59:30 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > 
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > > 
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > > 
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> > 
> > What are these use cases?
> 
> Buffers that contain LE or BE arrays that want
> to be emitted by print_hex_dump.

Make that "where are".

> > Will patches be forthcoming to convert them?
> 
> Sure, after a settling period for Masahiro's patch
> to be applied upstream.
> 
> https://lkml.org/lkml/2015/12/8/480

One single callsite under #ifdef DEBUG?  Doesn't seem to warrant adding
code and complexity to core library functions.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/